Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement UI for about page #325

Merged
merged 3 commits into from
Feb 20, 2023
Merged

implement UI for about page #325

merged 3 commits into from
Feb 20, 2023

Conversation

dario-piotrowicz
Copy link
Member

initial step for #282

Note: Currently it uses data I just copy pasted from Mastodon, but it is not accessible by the user since the page's loader redirects to /

Result:
Screenshot at 2023-02-20 18-04-28

Screenshot at 2023-02-20 18-05-02

@dario-piotrowicz
make playwright fail faster locally
501c840 
locally playwright is very fast and not flaky, so in order to
have a quicker development cycle reduce the playwright timeouts
so that if something is off playwright can fail tests quicker
@dario-piotrowicz
fix broken statusAPI.handleRequestGet call
40d59fb 
likely broken by PR #309
@dario-piotrowicz
implement UI for about page
3d0e394 
initial step for #282
xtuc
xtuc approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the page is hidden / not accessible at the moment

dario-piotrowicz
dario-piotrowicz commented Feb 20, 2023
View reviewed changes
frontend/src/routes/(frontend)/about/index.tsx

export const aboutInfoLoader = loader$<Promise<AboutInfo>>(async ({ resolveValue, request, redirect }) => {
// TODO: properly implement loader and remove redirect
throw redirect(302, '/')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtuc 🙂

@dario-piotrowicz
Copy link
Member Author

lgtm if the page is hidden / not accessible at the moment

yeah, as you can see here: https://github.com/cloudflare/wildebeest/pull/325/files#r1112297297 we just always unconditionally redirect to / when you try to access the page 🙂

@dario-piotrowicz dario-piotrowicz merged commit a2072d4 into main Feb 20, 2023
@dario-piotrowicz dario-piotrowicz deleted the about-page branch February 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtuc xtuc xtuc approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

@jculvey jculvey Awaiting requested review from jculvey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dario-piotrowicz @xtuc