Use configured client_secret in state to properly handle changes #4500
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
JonasBak
force-pushed
the
master
branch
3 times, most recently
from
10d4511
to
115332a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve the issue reported here: #4497
It should also fix an issue we experienced earlier (but which is now "replaced" with the issue listed above) where changes to the
client_secretdidn't trigger changes to thecloudflare_zero_trust_access_identity_providerresource.This PR will change the resource so the
client_secretis stored in state, so it can properly detect if the field has changed, and can trigger updates to the resource.