Fix ZT lists update #4477
Open
Fix ZT lists update #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
When updating the `cloudflare_zero_trust_list` only changes to the `items` field was being considered to determine the list elements to store. However, customers can also use the `items_with_description` field to declare list elements with a description, so it also needs to be considered. This commit fixes the issue, adding an acceptance test to prove its effectiveness.
sebassimoes
force-pushed
the
sebastia/gfi-536-fix-zt-list-items-update
branch
from
b48a204
to
bef5629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the
cloudflare_zero_trust_listonly changes to theitemsfield was being considered to determine the list elements to store. However, customers can also use theitems_with_descriptionfield to declare list elements with a description, so it also needs to be considered. This commit fixes the issue, adding an acceptance test to prove its effectiveness.