-
Notifications
You must be signed in to change notification settings - Fork 18
Add a zip option for the results. #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated the --zip option description in README.md.
Removed handling of zip options from configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just run the prettier and sync the readme text for it and it should be ready.
README.md
Outdated
| --html Generate HTML report (default: false) | ||
| --openHtml Open HTML report in browser (requires --html) (default: false) | ||
| --list Generate a list of test results as HTML (default: false) | ||
| --zip Zip the results of the test into the results directory (default: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to generate this by running telescope --help to keep readme and the code in sync.
lib/testRunner.js
Outdated
| event.element['content'] = style.content; | ||
| } | ||
| } catch (err) {} | ||
| } catch (err) { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run npm run prettier to format the code.
Using AdmZip for zipping results into the base
./resultsdirectory. Addresses issue #42.I went with Option 1 to zip and keep the files. Cleanup should be another option or part of housecleaning.