Fix lifecycle ordering bug removing recently added container #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Hey, could you write a test for this? |
nathanchrs
added a commit
to Dekoruma/react-gateway
that referenced
this pull request
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React 16, when swapping in components, componentWillMount now fires on the new components before componentWillUnmount fires on the old ones. This means that unmounting a GatewayDest and mounting one of the same name will call addContainer and removeContainer in the wrong order. As a result, the GatewayDest no longer receives updates from rerendered Gateways.
This PR makes it so that removeContainer checks what container it is removing and noops if it would remove the wrong container.