fix: fix udp socket create error #430
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
in these #352 #102 issues, someone mentioned that the performance is pretty low at the master branch, i encountered the same situation at my desktop and vps, so i checked out the previous commits and located the root cause.
root cause
from commit 5a49e83, the hand-written udp socket was changed to socket2. but in peer.rs, the udp socket's creation method's argument was wrong.
fix
Changed the socket type from
Type::STREAM
toType::DGRAM
to correctly handle UDP connections.tests
i have tested several commits's performance with iperf3. after the fix, the throughput was finally ok