fix: Removed dependency on base64 gem#85
Merged
dazuma merged 1 commit intocloudevents:mainfrom Sep 27, 2025
Merged
Conversation
Signed-off-by: Daniel Azuma <dazuma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces usage of the base64 gem with appropriate pack/unpack expressions. Removes base64, as well as a few other unnecessary standard library gems, from the Gemfile.
Note that our use of Array#pack uses the
m0code, which eliminates newlines from the base64 encoded value. This is a behavioral change from the original code, which includes the newlines. We're making this change because the application to JSON-encoded cloudevents, while not specifying one or the other, would probably prefer to omit the newlines.closes #82