[ui-storagebrowser] adds change owner and group action #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
nidhibhatg,
Harshg999,
JohanAhlen,
tabraiz12 and
bjornalm
bjornalm
reviewed
Jan 28, 2025
| @use 'variables' as vars; | ||
|
|
||
| .antd.cuix { | ||
| .change-owner-group { |
There was a problem hiding this comment.
nit: we prefix classes with hue-
| const groupOptions = getDropdownOptions(groups); | ||
|
|
||
| useEffect(() => { | ||
| const isOtherUserSelected = !users.includes(files[0].user); |
There was a problem hiding this comment.
With files[0].user you assume there is always at least on file in the array, is that guaranteed?
There was a problem hiding this comment.
Yes, the action will not be enabled until at-least one file is selected.
|
|
||
| const { save, loading } = useSaveData(BULK_CHANGE_OWNER_API_URL, { | ||
| postOptions: { | ||
| qsEncodeData: false |
There was a problem hiding this comment.
is this true by default?
There was a problem hiding this comment.
yes, It is undefined by default and const encodeData = options?.qsEncodeData == undefined || options?.qsEncodeData; condition turns encodeData value to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.