Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-leftassist] auto select next compute onError #3965

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • When the Virtual Compute is unavailable, the left assist will automatically retry using next compute.

How was this patch tested?

  • Manually tested

Please review Hue Contributing Guide before opening a pull request.

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this change?

@@ -146,8 +146,9 @@ const generateEntryCacheId = (options: {
path?: string | string[];
paths?: string[][];
namespace: Namespace;
compute: Compute;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't actually need the complete Compute, only the name

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 23, 2025 16:04
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@ramprasadagarwal ramprasadagarwal merged commit f6cd307 into master Jan 23, 2025
6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the fix/left-assist branch January 23, 2025 16:46
tabraiz12 pushed a commit that referenced this pull request Jan 27, 2025
* changes compute to computeName

(cherry picked from commit f6cd307)
(cherry picked from commit ec6bab66092188fadc677d419f68963d9843c48a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants