[computes] removed admissiond from impala readiness check #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitsrivastava
requested review from
wing2fly,
ranade1,
athithyaaselvam and
Harshg999
Harshg999
approved these changes
Jan 10, 2025
admissiond check is no longer needed. also fixed a few other bool conversions. the `is_ready` field currently has minimal effect on the UI. We return the results sorting the computes with ready ones on the top while non-ready ones at the bottom. In future, we should update the UI to indicate if a compute is ready to accept queries or not. This change also makes the compute.is_ready nullable/optional because it is not in full use yet and should not effect inserts and updates.
amitsrivastava
force-pushed
the
dev/amit/fix-impala-readiness-check
branch
from
e38cdbd to
08969bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admissiond check is no longer needed.
also fixed a few other bool conversions.
the
is_readyfield currently has minimal effect on the UI. We return the results sorting the computes with ready ones on the top while non-ready ones at the bottom. In future, we should update the UI to indicate if a compute is ready to accept queries or not.This change also makes the compute.is_ready nullable/optional because it is not in full use yet and should not effect inserts and updates.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.