[ui-metrics] Converted the Metrics page within Admin Server in ReactJS #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananya-agarwal
force-pushed
the
metricsNew
branch
from
7cf2b7d to
6d965ea
Compare
ananya-agarwal
force-pushed
the
metricsNew
branch
from
d607939 to
3376a13
Compare
ananya-agarwal
force-pushed
the
metricsNew
branch
from
2d0d124 to
add0b4b
Compare
Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4
ananya-agarwal
commented
Jun 14, 2024
desktop/core/src/desktop/js/reactComponents/MetricsComponent/MetricsComponent.test.tsx
Outdated
Show resolved
Hide resolved
ananya-agarwal
force-pushed
the
metricsNew
branch
from
fe9cbaa to
cb558d4
Compare
ananya-agarwal
force-pushed
the
metricsNew
branch
from
fc0341f to
0b94ee8
Compare
Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4
…after saving state
Alterrien
pushed a commit
to Alterrien/hue
that referenced
this pull request
Dec 19, 2024
cloudera#3707) * [ui-metrics] Converted the Metrics page within Admin Server in ReactJS * Fixing issues for removing the errors * Fixing the linting issues * metricsNew * Fixing lints in MetricsTable * Fixing the tests-unnecessary changes * Fixing the unit test, missing return type errors, any return type error * Not hardcoding the metrics keys and generating dynamically * WIP * Updated the test for the review * WIP * fix unit test Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4 * Fixed unit test for select with proper linting * Fixing the style issues * replace click with mouseDown for clicking the dropDown * Filtering the metrics and removing python.gc, multiprocessing, auth starting metrics * Fixing the linting issues * Removing matchMedia as it is not required anymore * Remove the unneccessary comments * Proper heading to h4 tag * remove the snake_case and add i18n * Fixing the linting issues * Fixing based on Bjorn's review comments * Updating based on Tabriz's PR review comments * Fixing linting issues * Changing the metrics only to the required fields in metricsTable * Fixing style issues * Removing the shadow within the input filter * Filtering done inside useEffect hook only and removed from elsewhere after saving state * Revertung box shadow changes * [ui-metrics] Converted the Metrics page within Admin Server in ReactJS * Fixing issues for removing the errors * Fixing the linting issues * metricsNew * Fixing lints in MetricsTable * Fixing the tests-unnecessary changes * Fixing the unit test, missing return type errors, any return type error * Not hardcoding the metrics keys and generating dynamically * WIP * Updated the test for the review * WIP * fix unit test Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4 * Fixed unit test for select with proper linting * Fixing the style issues * replace click with mouseDown for clicking the dropDown * Filtering the metrics and removing python.gc, multiprocessing, auth starting metrics * Fixing the linting issues * Removing matchMedia as it is not required anymore * Remove the unneccessary comments * Proper heading to h4 tag * remove the snake_case and add i18n * Fixing the linting issues * Fixing based on Bjorn's review comments * Updating based on Tabriz's PR review comments * Fixing linting issues * Changing the metrics only to the required fields in metricsTable * Fixing style issues * Removing the shadow within the input filter * Filtering done inside useEffect hook only and removed from elsewhere after saving state * Revertung box shadow changes * grey line removal WIP * Box shadow final removal * fixing indentation * Removing unneccesary comments --------- Co-authored-by: tabraiz <[email protected]>
tabraiz12
pushed a commit
that referenced
this pull request
Jan 27, 2025
…er in ReactJS (#3707) * [ui-metrics] Converted the Metrics page within Admin Server in ReactJS * Fixing issues for removing the errors * Fixing the linting issues * metricsNew * Fixing lints in MetricsTable * Fixing the tests-unnecessary changes * Fixing the unit test, missing return type errors, any return type error * Not hardcoding the metrics keys and generating dynamically * WIP * Updated the test for the review * WIP * fix unit test Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4 * Fixed unit test for select with proper linting * Fixing the style issues * replace click with mouseDown for clicking the dropDown * Filtering the metrics and removing python.gc, multiprocessing, auth starting metrics * Fixing the linting issues * Removing matchMedia as it is not required anymore * Remove the unneccessary comments * Proper heading to h4 tag * remove the snake_case and add i18n * Fixing the linting issues * Fixing based on Bjorn's review comments * Updating based on Tabriz's PR review comments * Fixing linting issues * Changing the metrics only to the required fields in metricsTable * Fixing style issues * Removing the shadow within the input filter * Filtering done inside useEffect hook only and removed from elsewhere after saving state * Revertung box shadow changes * [ui-metrics] Converted the Metrics page within Admin Server in ReactJS * Fixing issues for removing the errors * Fixing the linting issues * metricsNew * Fixing lints in MetricsTable * Fixing the tests-unnecessary changes * Fixing the unit test, missing return type errors, any return type error * Not hardcoding the metrics keys and generating dynamically * WIP * Updated the test for the review * WIP * fix unit test Change-Id: I641dfe1152e184e8501dc718e49f4e038bbe69c4 * Fixed unit test for select with proper linting * Fixing the style issues * replace click with mouseDown for clicking the dropDown * Filtering the metrics and removing python.gc, multiprocessing, auth starting metrics * Fixing the linting issues * Removing matchMedia as it is not required anymore * Remove the unneccessary comments * Proper heading to h4 tag * remove the snake_case and add i18n * Fixing the linting issues * Fixing based on Bjorn's review comments * Updating based on Tabriz's PR review comments * Fixing linting issues * Changing the metrics only to the required fields in metricsTable * Fixing style issues * Removing the shadow within the input filter * Filtering done inside useEffect hook only and removed from elsewhere after saving state * Revertung box shadow changes * grey line removal WIP * Box shadow final removal * fixing indentation * Removing unneccesary comments --------- Co-authored-by: tabraiz <[email protected]> (cherry picked from commit bdeccbd) Change-Id: Iea7ff1246370706d2242e67b3cd2c8a268bf53f5 (cherry picked from commit 5263f18fe4c374834e488cb8278280ce1422d1f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is about shifting the entire code for the Metrics tab (page) in ReactJS i.e. adding Metrics as a react component. The Metrics page is present as a tab in the Administrator server.
How was this patch tested?
I have added unit tests here. One for the selection dropDown and the other for filtering the metrics based on name.
The code is tested manually as well.
This is how the current Metrics page looks like.
Please review Hue Contributing Guide before opening a pull request.