New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update execution package #34

Merged

gabriel-samfira merged 2 commits into cloudbase:main from fabi200123:update-common

Sep 6, 2024

Contributor

fabi200123 commented Sep 6, 2024

Updates func GetEnvironment(version ...string) to get the environment based on the version received from external-provider
Updates Run() to be a method of the Environment struct
Removes the need for a common ExternalProvider interface in favor of doing a cast during the call of Run()
Removes semver dependency
Adds for v0.1.1 a new command GetSupportedInterfaceVersions


          Add GetSupportedInterfaceVersions command for v0.1.1

d5373f3

fabi200123 force-pushed the update-common branch from 89e2356 to cae4663 Compare

September 6, 2024 08:48


          Update execution

51370ba

fabi200123 force-pushed the update-common branch from cae4663 to 51370ba Compare

September 6, 2024 08:49

gabriel-samfira reviewed

View reviewed changes

execution/v0.1.1/execution_test.go

               	return "v0.1.1"
               }
+              func (p *testExternalProvider) GetSupportedInterfaceVersions(context.Context) []string {
+              	//TODO: implement
+              	return []string{"v0.1.0", "v0.1.1"}

Member

gabriel-samfira Sep 6, 2024

yup. We may add a new param to describe interface versions with more than just the string itself. But in another PR after we give it some thought.

gabriel-samfira approved these changes

View reviewed changes

gabriel-samfira merged commit 57315d4 into cloudbase:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet