Merge pull request #33 from fabi200123/minor-fix

fix: Adds validation for the new commands
cloudbase · Sep 4, 2024 · 817280b · 817280b
2 parents dfdf8e2 + 0eb0ffc
commit 817280b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/execution/v0.1.0/execution.go b/execution/v0.1.0/execution.go
@@ -106,7 +106,7 @@ func (e EnvironmentV010) Validate() error {
 			return fmt.Errorf("missing controller ID")
 		}
 	case common.GetVersionCommand:
-		if semver.IsValid(e.InterfaceVersion) {
+		if !semver.IsValid(e.InterfaceVersion) {
 			return fmt.Errorf("invalid interface version: %s", e.InterfaceVersion)
 		}
 	default:

diff --git a/execution/v0.1.1/execution.go b/execution/v0.1.1/execution.go
@@ -112,7 +112,12 @@ func (e EnvironmentV011) Validate() error {
 			return fmt.Errorf("missing controller ID")
 		}
 	case common.GetVersionCommand:
-		if semver.IsValid(e.InterfaceVersion) {
+		if !semver.IsValid(e.InterfaceVersion) {
+			return fmt.Errorf("invalid interface version: %s", e.InterfaceVersion)
+		}
+	case common.ValidatePoolInfoCommand, common.GetConfigJSONSchemaCommand,
+		common.GetExtraSpecsJSONSchemaCommand:
+		if !semver.IsValid(e.InterfaceVersion) && e.InterfaceVersion == common.Version010 {
 			return fmt.Errorf("invalid interface version: %s", e.InterfaceVersion)
 		}
 	default: