fix(otp): shorten the ping period for monitoring the CouchDB node
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgj
force-pushed
the
revisit-remote-node-ping-timeout
branch
2 times, most recently
from
1deb5aa to
0116491
Compare
It is not recommended to specify very long timeout when calling the `OtpNode#ping` method. There is only a single attempt is made to connect to the remote node. This is also a blocking call where it is not so useful to keep it waiting for a long time.
pgj
force-pushed
the
revisit-remote-node-ping-timeout
branch
from
0116491 to
efe7774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not recommended to specify very long timeout when calling the
OtpNode#pingmethod. There is only a single attempt is made to connect to the remote node. This is also a blocking call where it is not so useful to keep it waiting for a long time.