Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provision of cron expressions for periodic task scheduling. #307

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

vishesh10
Copy link
Contributor

This is in continuation to the PR #71

Description

Added provision of cron expressions to facilitate the scheduling of tasks.

Changes

  • Added new feature of cron expression
  • Added test cases
  • updated README

Copy link
Contributor

@AlecRosenbaum AlecRosenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks pretty good to me! I enabled workflows for this PR and it seems there's a few linting issues.

@thomasst assuming those are addressed, would you have any issues with merging this?

@thomasst
Copy link
Member

thomasst commented Nov 6, 2023

Looks good overall!

@vishesh10 vishesh10 force-pushed the feat_cron branch 2 times, most recently from daff844 to 33da29a Compare November 6, 2023 18:39
@AlecRosenbaum AlecRosenbaum merged commit 7496a77 into closeio:master Nov 7, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants