Custom serializers #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliewolf
force-pushed
the
custom-serializers
branch
from
3936793 to
5debfca
Compare
|
Addresses #21 |
thomasst
reviewed
Nov 12, 2016
| @@ -12,7 +11,7 @@ class Task(object): | |||
| def __init__(self, tiger, func=None, args=None, kwargs=None, queue=None, | |||
| hard_timeout=None, unique=None, lock=None, lock_key=None, | |||
| retry=None, retry_on=None, retry_method=None, | |||
| _data=None, _state=None, _ts=None, _executions=None): | |||
| _data=None, _state=None, _ts=None, _executions=None, deserialize=json.loads, serialize=json.dumps): | |||
thomasst
reviewed
Nov 12, 2016
| @@ -132,10 +132,17 @@ def __init__(self, connection=None, config=None, setup_structlog=False): | |||
|
|
|||
| # If non-empty, a worker only processeses the given queues. | |||
| 'ONLY_QUEUES': [], | |||
|
|
|||
There was a problem hiding this comment.
Would be nice to have a quick comment just like the other settings.
thomasst
reviewed
Nov 12, 2016
| @@ -1,3 +1,4 @@ | |||
| import pickle | |||
There was a problem hiding this comment.
I preferably don't want to mention pickle in this package since it suggests that this would be a sane choice. A better example would be JSON with a custom JSONEncoder/JSONDecoder. This would then also ensure that the given serialization is actually being used (since the default encoder would throw an error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.