Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include original task id with batched parameters #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Include original task id with batched parameters #169

wants to merge 3 commits into from

Conversation

jkemp101
Copy link
Member

This allows clients to know which task ID a set of parameters came from. Useful for logging purposes.

@jkemp101 jkemp101 requested a review from thomasst December 14, 2020 20:42
@thomasst
Copy link
Member

Would tiger.current_tasks[N].id be sufficient to do this? For a single task you'd also use tiger.current_task.id to get the ID.

@thomasst
Copy link
Member

What do we want to decide here?

@jkemp101 jkemp101 removed the request for review from thomasst December 22, 2020 19:28
@jkemp101
Copy link
Member Author

I started an alternative implementation using your suggestion. I removed you as a reviewer on this one.

@jkemp101 jkemp101 mentioned this pull request Dec 22, 2020
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkemp101 @thomasst