Flake8: remove unused imports #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeaky-pl
commented
Oct 5, 2021
|
Need to investigate this, it seems to be consistently failing in CircleCI but not locally. |
squeaky-pl
changed the title
AlecRosenbaum
approved these changes
Feb 15, 2022
tests/contacts/test_remote_sync.py
Outdated
| @@ -97,7 +97,7 @@ def test_auth_error_handling(contact_sync, default_account, db): | |||
| db.session.commit() | |||
|
|
|||
| contact_sync.start() | |||
| contact_sync.join(timeout=10) | |||
| contact_sync.join(timeout=15) | |||
There was a problem hiding this comment.
it this needed still? It looks like the test would be skipped
There was a problem hiding this comment.
Right, I added a separate issue about removing it.
|
This triggered following error in
All the other pods seemed to be working correctly. Need to figure out which import has side effects of fully initializing SQLAlchemy in delete-accounts pod. |
|
This has rotten now, will open another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.