Don't break on missing categories #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeaky-pl
commented
Mar 16, 2023
| sent_recent_date = m.received_date | ||
| for message in sorted_messages: | ||
| if "sent" in [ | ||
| category.name for category in message.categories if category |
There was a problem hiding this comment.
if category is the part that I added to filter out None categories that come from missing categories because of missing FK.
drewler
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop gap solution for #302.
There's a pretty laud rollbar both on CRM and sync-engine side.
categorycan be None because somebody at Nylas decided to drop a foreign key mentioned in the issue. We should still investigate if we can add those constraints back because the decision to drop such constraints does not look like a correct one to me. In the meantime let's ship this because for people that hit this problem we simply get stuck on this and stop syncing their inboxes.