Use end instead of start #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logically this makes more sense, since find_unwrap_start can theoretically return a distinct start and end. Although in practice the headers could appear only in "forward" scenario where start and end are the same, so this doesn't really matter. If you'd like to artificially build a test case where the previous code would fail, you'd put the forward pattern on two lines: ---------- Forwarded message ---------- From: Someone <[email protected]> Date: Fri, Apr 26, 2013 at 8:13 PM Subject: Weekend Spanish classes
Same as before for headers starting, this makes more sense logically, if the previous pattern occupies two lines instead of one. One could artifically build a scenario where the reply header takes two lines and the quoted text doesn't have ">" in it, to reach this else branch logic: On 2012-10-16 at 17:02 , Someone <[email protected]> wrote: Some quoted text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes don't modify the current functionality but, as mentioned in the commit message descriptions, it logically makes more sense to use
endinstead ofstart, sincefind_unwrap_startcould return astart != end, and in those cases we'd like to start looking for headers fromend+1instead of fromstart+1. Furthermore, if the headers don't start at the first line,extract_headerswill fail, so another argument to useend + 1.Do you think I should add some "artificially" created tests for these updates? Like mentioned in the comments, some of them would look like:
and
notice that in both cases the header line for reply/forward takes two lines so this makes
end != startas returned byfind_unwrap_start, but that shouldn't really happen in real emails since those look poorly formatted and email clients would probably fix this?