Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run npm audit fix for @babel/traverse #7

Merged
merged 2 commits into from
Oct 25, 2023
Merged

run npm audit fix for @babel/traverse #7

merged 2 commits into from
Oct 25, 2023

Conversation

andrejunges
Copy link
Contributor

@andrejunges andrejunges commented Oct 24, 2023

Just run npm audit fix to remove the vulnerabilities warnings we had related to @babel/traverse

@andrejunges andrejunges self-assigned this Oct 24, 2023
Copy link

@bartgryszko bartgryszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried running the best-practices-documentation script after the update?

package-lock.json Show resolved Hide resolved
@andrejunges
Copy link
Contributor Author

Have you tried running the best-practices-documentation script after the update?

My test was installing that specific version in close-ui and running best-practices:check and best-practices:build - which worked fine as far as I can tell.

"@closeio/best-practices-documentation": "closeio/best-practices-documentation#audit-fix",

package-lock.json Show resolved Hide resolved
@andrejunges andrejunges merged commit 0cb3cb1 into main Oct 25, 2023
2 checks passed
@andrejunges andrejunges deleted the audit-fix branch October 25, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants