Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize mdx jsx comments #5

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Recognize mdx jsx comments #5

merged 3 commits into from
Sep 7, 2023

Conversation

treycucco
Copy link
Collaborator

Recognize JSX-style comments in .mdx files. E.g. {/* @BestPractice.insert <block id> */} instead of <!-- @BestPractice.insert <block id> -->;

@treycucco treycucco requested a review from ggogobera September 7, 2023 17:50
ggogobera
ggogobera approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ggogobera ggogobera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@treycucco
Copy link
Collaborator Author

I tried the local build against our docs and it works

@treycucco treycucco merged commit 1961b84 into main Sep 7, 2023
2 checks passed
@treycucco treycucco deleted the recognize-mdx-jsx-comments branch September 7, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggogobera ggogobera ggogobera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treycucco @ggogobera