Conversation
This reverts commit eacf501.
Collaborator
|
Hi @vlordier. Thanks for the PR. I see quite a few issues with the code though. I started a review, but there's a higher level question that probably should be answered first, which is: what should the formatting standard for the project be? I use Black + Flake8 personally, and would advocate for that to be the standard (something like https://github.com/hafriedlander/stable-diffusion-grpcserver/blob/main/.vscode/settings.json) - @cloneofsimo do you have any preferences? |
Collaborator
|
Oh, also, PRs should be raised against |
Owner
|
Yes it seems like many differences come from formatting. I think I use black with default linebreaks but ill notify when Im home |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a bit of code cleanup & comments to make the code bit more accessible, no functional changes