Add support for the Bun and pnpm package managers. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commiterate
changed the title
commiterate
force-pushed
the
deps-cmd-add-bun-pnpm
branch
3 times, most recently
from
418d878
to
d713463
Compare
commiterate
force-pushed
the
deps-cmd-add-bun-pnpm
branch
from
d713463
to
45cabc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mirroring a similar contribution to shadow-cljs.
See the shadow-cljs issue for a more detailed "why".
This also adds support for
node_modulesindexing with the Bun runtime.Testing
I've avoided adding additional tests in
src/test/clojure/cljs/foreign/node_test.cljfor the time being since I'm not sure how the ClojureScript CI environment is configured (not sure if Bun and pnpm are available).Instead, I created a test repository with a barebones CLJS project using the fork (sourced in
deps.ednwith thegitprocurer).https://github.com/commiterate/test-clojurescript-bun
This repository uses Emmy to create a Node.js application that just prints 21 (using Emmy's
exp2function) to stdout.A reproducible shell is provided with Nix for additional testing by the ClojureScript team and others.
There's notes in the test repository's readme detailing some sharp edges with:
tools.build(classpath issues breakingdeps.cljssearches).These might be of interest to the ClojureScript team for future improvements.