snapshot: More Snapshot accessors
#1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Make the `database_address` and `database_instance_id` of `Snapshot` `pub`. Also provide a method to obtain an iterator over all object hashes the `Snapshot` is referring to. This allows to fetch a snapshot over the network in a streaming fashion, avoiding to download objects which already exist.
kim
force-pushed
the
kim/snapshot/more-pub
branch
from
8410209
to
350b3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
database_addressanddatabase_instance_idofSnapshotpub. Also provide a method to obtain an iterator over all object hashes theSnapshotis referring to.This allows to fetch a snapshot over the network in a streaming fashion, avoiding to download objects which already exist.
Expected complexity level and risk
1
Testing
n/a