Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - Remove unused tracelog.rs #1693

Merged
merged 2 commits into from
Sep 20, 2024
Merged

CLI - Remove unused tracelog.rs #1693

merged 2 commits into from
Sep 20, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Sep 10, 2024

Description of Changes

This tracelog subcommand was removed, but the file was left around. This PR removes it.

API and ABI breaking changes

No

Expected complexity level and risk

1

Testing

Existing CI only.

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Sep 10, 2024
mamcx
mamcx approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit b123f53 Sep 20, 2024
8 checks passed
@bfops bfops deleted the bfops/cli-remove-tracelog branch October 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

Assignees
No one assigned
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfops @mamcx