Rework Rust SDK for new API #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enough of the Rust SDK rework to run `quickstart-chat`. Still TODO: - Implement new codegen. Currently I have manually written the bindings for `quickstart-chat`. A future commit will update the CLI codegen to generate files similar to those I wrote by hand. - Subscription modification / mutable subscription sets. This is waiting on actually implementing the internals. - Identity and auth rework. This is waiting on that proposal being accepted and implemented. - Non-unique BTree indices. `quickstart-chat` happens to not use any of these. - Supporting PKs of arbitrary SATS types. Currently we impose `Hash + Eq` because it's easier. - Docs, both internal and external. - Updating the SDK tests.
At least, enough codegen to run quickstart-chat
So that codegen can emit separate table defns and type defns for them
May restore it at some point, but for now I'm not updating it.
…ust-sdk This involved a fairly significant re-rewrite of Rust codegen, as we had two incopatible parent branches, neither of which was the desired version. `master` had the input changes for the new `ModuleDef`, and this branch had the output changes for the new SDK. Post-merge, this branch has both the input and the output changes.
Currently failing because I haven't (re-)implemented graceful disconnect.
This will be reworked after the identity changes, but those will not be in the 0.12 release.
Any WS message which invokes multiple callbacks will do so with a lock held, which means that any callback which tries to get the lock will deadlock. As written, `ctx.identity()` tries to get the lock.
At least, specifically with Rust modules, since I can't run dotnet...
- Update insta snap for new Rust codegen - Don't pass a non-default namespace to Rust or TypeScript codegen in tests. Rust errors if you do; TypeScript should error but doesn't.
kim
approved these changes
Sep 25, 2024
I'd still like to add doc comments to the codegen
So that you can wrap the constructor in a function, like the tests do.
…/SpacetimeDB into phoebe/db-context/rust-sdk
coolreader18
approved these changes
Sep 27, 2024
Luckily we have pretty good test coverage to demonstrate that the thing works, so my main concern is that it matches the proposal and the other impls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The Rust SDK rework for the new stable API!
Still TODO, to be follow-ups:
Hash + Eqbecause it's easier.Reworks the Rust SDK to match the new stable API. This includes a significant rewrite of the SDK internals, since the previous internals were ill-suited to implement the new API.
API and ABI breaking changes
Oh baby it sure is!
Expected complexity level and risk
3 - A pretty major rewrite of the Rust SDK, but we have reasonable test coverage.
Testing
resubscribe, which is currently disabled and would be broken.