-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link feature to families #49
Conversation
I think Simon should review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting together a sqlalchemy ORM query in python code may be somewhat more elegant (in particular since this would take care of the joined inheritance automatically), but then, shuffling results back and forth between view and backend would add bloat as well.
So I think this is fine as is.
I think right now it might be best to just merge this and push it to the webapp. Then everybody can look at it on the running site, click all the things, and see if there are problems/suggestions/etc. |
Please wait with deploying changes to the web app until the current status is reviewed and ok-ed by project lead. |
Got it |
Seems like this PR got lost in the shuffle during release. Do we want to merge it now? |
I think so, but I don't know who we're waiting for here. |
If we want Simon to review, someone needs to add him to the repos. |
I'm not sure what to review here -- the code all looks sensible to me but I'd need to see it on the webpage. Can we merge and deploy and then refine if needed? |
Okay, I redeployed (which also includes the changes made to address #74). If you wanna have a look, here's some links to the changed pages: You can choose a feature at the top of the family page (I think that worked before the PR); e.g. Arawakan:
You can choose a language family on the feature page, above the map, right where the Combine Two Features with Each Other button is as well; e.g. GB074:
And here's the combination page of Arawakan+GB074:
|
@SimonGreenhill Is this to your satisfaction? |
thanks @johenglisch -- looks good. Is there any chance to have the map and the phylogeny side by side ? (e.g. a div with 80% map, 20% tree) |
actually exist (example of a non-existing combination:
https://grambank.clld.org/familys/kres1240?feature=GB432#0/0/0)