Transport position in ex-data

[ferdinand-beyer]

Exceptions thrown by the reader will have :row and :col keys in their ex-data.

[borkdude]

@lread I approve this PR. Maybe it would be nice to add a :type :rewrite-clj or so to the ex-data too.

[ferdinand-beyer]

Note the TypeError: Right-hand side of 'instanceof' is not an object -- I think this is an unrelated issue with error reporting in ClojureScript?

[ferdinand-beyer]

Argh, nevermind. The issue is my catch Exception -- that does not work in cljs. Fixing...

[lread]

Argh, nevermind. The issue is my catch Exception -- that does not work in cljs. Fixing...

Another way to fix is to catch ExceptionInfo instead.

[borkdude]

In some test code I write:

#?(:cljs (def Exception js/Error))

which is a hack, but it does work :)

[lread]

@lread I approve this PR. Maybe it would be nice to add a :type :rewrite-clj or so to the ex-data too.

@borkdude, I also think adding :type :rewrite-clj makes sense. I'll raise a separate issue for that.

[ferdinand-beyer]

Maybe namespaced :type would make sense, eg. :rewrite-clj/parse-error. This would allow for easier integration with other tools, allows for derive -ing, and extension to different kinds of errors in the future?

[borkdude]

I've done something similar in SCI: :sci/error + isa?.

[lread]

Maybe namespaced :type would make sense, eg. :rewrite-clj/parse-error. This would allow for easier integration with other tools, allows for derive -ing, and extension to different kinds of errors in the future?

Yah maybe! Let's discuss in #182