fix reported difference in datetime when passed in a date in the future (addresses #44) #45

jf · 2024-11-15T23:06:20Z

Addresses #44

I considered a couple of approaches, ranging from adding the current time (and then with a +1 second; good grief! just in order to be able to bump it up at the nanosecond-level to just past 24 hours) to then-dt using atTime, to maybe doing something with the cond if passed in a date; but ultimately settled on this one as the most elegant.

A couple of notes:

~~I must apologize for not adding in tests for this just yet; I can take a look at this in time to come (but would also be fine getting help for this)~~ DONE
I decided to make (datetime (java.time.LocalDate/now)) equal "today" (rather than "a moment ago"); I think that makes sense

we do this by simply "coercing" the :now-dt argument to be ~at midnight as well~ when then-dt is a java.time.LocalDate

fix reported difference in datetime when passed in a date in the future;

027db4a

we do this by simply "coercing" the :now-dt argument to be ~at midnight as well~ when then-dt is a java.time.LocalDate

jf requested a review from hlship as a code owner November 15, 2024 23:06

jf added 2 commits November 16, 2024 11:26

add tests for datetime handling of date arguments

7bd8d8f

update datetime tests to include ldt :dt-now argument

f9ce047

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix reported difference in datetime when passed in a date in the future (addresses #44) #45

fix reported difference in datetime when passed in a date in the future (addresses #44) #45

jf commented Nov 15, 2024 •

edited

Loading

fix reported difference in datetime when passed in a date in the future (addresses #44) #45

Are you sure you want to change the base?

fix reported difference in datetime when passed in a date in the future (addresses #44) #45

Conversation

jf commented Nov 15, 2024 • edited Loading

jf commented Nov 15, 2024 •

edited

Loading