[PARKED] Area chart light theme colours #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add failing test for #303 * Detect module name for eval frames
admataz
force-pushed
the
area-chart-light-theme-colours
branch
from
fc653c4
to
b1697d9
Compare
goto-bus-stop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this branch is is based from the
new-render-methodsbranch, as it contains the necessary abstractions for css->canvas - once #317 is approved and merged, this can be rebased to master.Issue
Generally, this allows the UI to respond to theme switching via an emitted event - and for the CSS to canvas abstraction to return different values according to the active theme.
Specifically it addresses the issue, and adjusts the colours for the canvas rendered area chart according to the active theme.