-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dia.Graph): add transferCellEmbeds() and transferCellConnectedLinks() #2752
Merged
kumilingus
merged 10 commits into
clientIO:master
from
MartinKanera:transfer-cell-hierarchy-links
Oct 23, 2024
Merged
feat(dia.Graph): add transferCellEmbeds() and transferCellConnectedLinks() #2752
kumilingus
merged 10 commits into
clientIO:master
from
MartinKanera:transfer-cell-hierarchy-links
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumilingus
reviewed
Sep 6, 2024
kumilingus
reviewed
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both methods should run inside a batch:
transfer-links
transfer-hiearchy
Thoughts on the naming of the functions:
|
|
MartinKanera
changed the title
feat(dia.Graph): add transferCellHierarchy() and transferCellLinks()
feat(dia.Graph): add transferCellEmbeds() and transferCellConnectedLinks()
Oct 3, 2024
kumilingus
reviewed
Oct 22, 2024
kumilingus
reviewed
Oct 22, 2024
kumilingus
reviewed
Oct 22, 2024
kumilingus
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
graph.transferCellEmbeds()
andgraph.transferCellConnectedLinks()
.Change the
dia.Cell.embed
method to acceptopt.reparent
.Documentation
transferCellEmbeds()
Transfer embedded cells of
sourceCell
totargetCell
.transferCellConnectedLinks()
Transfer all the links connected to
sourceCell
totargetCell
.embed()
...
The
opt.reparent
option can be set totrue
to transfer the embedded cells from their current parent to the new parent.