Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(repo): Require user permissions check to run jobs #4739

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Dec 9, 2024

Description

Follow up from user permissions job introduced on #4739

Must be merged before #4692, otherwise the CI won't allow updating the for needs + changing the trigger type on the same PR.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: CI

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:29pm

@LauraBeatris LauraBeatris self-assigned this Dec 9, 2024
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 8b246a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris force-pushed the laura/ci-permissions-check-2 branch from ecd812c to 8b246a5 Compare December 9, 2024 20:26
@LauraBeatris LauraBeatris requested a review from a team December 9, 2024 20:27
@LauraBeatris LauraBeatris marked this pull request as ready for review December 9, 2024 20:27
Copy link
Member

@jacekradko jacekradko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! 👍🏼

@LauraBeatris LauraBeatris merged commit 2657437 into main Dec 9, 2024
30 checks passed
@LauraBeatris LauraBeatris deleted the laura/ci-permissions-check-2 branch December 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants