Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(repo): Use pull_request_target event by triggering actor permissions #4692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci(repo): Use pull_request_target event by triggering actor permissions #4692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d35b632
Remove unused workflow input
LauraBeatris Dec 2, 2024
ceb4277
Do not use environment protection rule, rely on workflow run
LauraBeatris Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/nine-grapes-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: CI

on:
merge_group:
pull_request:
pull_request_target:
types: [opened, synchronize]
branches:
- main
- release/v4
Expand All @@ -12,7 +13,7 @@ concurrency:
cancel-in-progress: true

jobs:
# Check triggering actor permissions to prevent PRs from forks accessing secrets by default, preventing them from exfiltrating secrets for malicious purposes
# Check triggering actor permissions to prevent PRs from forks accessing secrets by default, preventing them from accessing secrets for malicious purposes
check-permissions:
runs-on: 'blacksmith-8vcpu-ubuntu-2204'
steps:
Expand Down Expand Up @@ -47,6 +48,7 @@ jobs:
with:
fetch-depth: 0
show-progress: false
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup
id: config
Expand Down Expand Up @@ -118,6 +120,7 @@ jobs:
with:
fetch-depth: 0
show-progress: false
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup
id: config
Expand Down Expand Up @@ -179,6 +182,7 @@ jobs:
with:
fetch-depth: 0
show-progress: false
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup
id: config
Expand Down
Loading