Remove hash method.

it cannot be guaranteed that objects which compare equal have the same hash value

.pre-commit-config.yaml

@@ -31,11 +31,6 @@ repos:
     rev: v0.3.1
     hooks:
       - id: absolufy-imports
-  - repo: https://github.com/hakancelikdev/unimport
-    rev: 1.1.0
-    hooks:
-      - id: unimport
-        args: [--remove, --include-star-import, --ignore-init, --gitignore]
   - repo: https://github.com/pycqa/isort
     rev: 5.12.0
     hooks:

docs/HISTORY.rst

@@ -5,7 +5,7 @@ Changelog
 ------------------
 
  - remove Python 3.7 support
- - Geometries are now immutable and hashable
+ - Geometries are now immutable (but not hashable)
  - add ``force_2d`` and ``force_3d`` factories [Alex Svetkin]
 
 1.1.1 (2023/10/27)

pygeoif/geometry.py

@@ -67,9 +67,6 @@ def __delattr__(self, *args: Any) -> NoReturn:  # noqa: ANN401
             msg,
         )
 
-    def __hash__(self) -> int:
-        return hash(self._geoms)
-
     def __str__(self) -> str:
         return self.wkt
 
@@ -1095,10 +1092,6 @@ def __eq__(self, other: object) -> bool:
             second=other.__geo_interface__,  # type: ignore [attr-defined]
         )
 
-    def __hash__(self) -> int:
-        """Return the hash of the collection."""
-        return hash(self.wkt)
-
     def __len__(self) -> int:
         """
         Length of the collection.

tests/test_geometrycollection.py

@@ -425,39 +425,3 @@ def test_nested_geometry_collection_repr_eval() -> None:
         ).__geo_interface__
         == gc.__geo_interface__
     )
-
-
-def test_nested_geometry_collection_hash() -> None:
-    multipoint = geometry.MultiPoint([(0, 0), (1, 1), (1, 2), (2, 2)])
-    gc1 = geometry.GeometryCollection([geometry.Point(0, 0), multipoint])
-    line1 = geometry.LineString([(0, 0), (3, 1)])
-    gc2 = geometry.GeometryCollection([gc1, line1])
-    poly1 = geometry.Polygon([(0, 0), (1, 1), (1, 0), (0, 0)])
-    e = [(0, 0), (0, 2), (2, 2), (2, 0), (0, 0)]
-    i = [(1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)]
-    poly2 = geometry.Polygon(e, [i])
-    p0 = geometry.Point(0, 0)
-    p1 = geometry.Point(-1, -1)
-    ring = geometry.LinearRing([(0, 0), (1, 1), (1, 0), (0, 0)])
-    line = geometry.LineString([(0, 0), (1, 1)])
-    gc = geometry.GeometryCollection([gc2, poly1, poly2, p0, p1, ring, line])
-
-    assert hash(gc) == hash(
-        geometry.GeometryCollection(
-            [
-                gc2,
-                poly1,
-                poly2,
-                p0,
-                p1,
-                ring,
-                line,
-            ],
-        ),
-    )
-
-
-def test_hash_empty() -> None:
-    gc = geometry.GeometryCollection([])
-
-    assert hash(gc) == hash(geometry.GeometryCollection([]))

tests/test_line.py

@@ -19,12 +19,6 @@ def test_coords_get_3d() -> None:
     assert line.coords == ((0.0, 0.0, 0), (1.0, 1.0, 1))
 
 
-def test_hash() -> None:
-    line = geometry.LineString([(0, 0, 0), (1, 1, 1)])
-
-    assert hash(line) == hash(geometry.LineString([(0, 0, 0), (1, 1, 1)]))
-
-
 def test_set_geoms_raises() -> None:
     line = geometry.LineString([(0, 0), (1, 0)])  # pragma: no mutate
 

tests/test_linear_ring.py

@@ -240,9 +240,3 @@ def test_empty_bounds() -> None:
     ring = geometry.LinearRing([])
 
     assert ring.bounds == ()
-
-
-def test_hash() -> None:
-    ring = geometry.LinearRing([(0, 0), (4, 0), (4, 2), (0, 2)])
-
-    assert hash(ring) == hash(((0, 0), (4, 0), (4, 2), (0, 2), (0, 0)))

tests/test_multiline.py

@@ -200,11 +200,3 @@ def test_empty_bounds() -> None:
     lines = geometry.MultiLineString([])
 
     assert lines.bounds == ()
-
-
-def test_hash() -> None:
-    lines = geometry.MultiLineString(([(0, 0), (1, 1)], [[0.0, 0.0], [1.0, 2.0]]))
-
-    assert hash(lines) == hash(
-        geometry.MultiLineString(([(0, 0), (1, 1)], [[0.0, 0.0], [1.0, 2.0]])),
-    )

tests/test_multipoint.py

@@ -148,12 +148,6 @@ def test_from_points_unique() -> None:
     )
 
 
-def test_hash() -> None:
-    multipoint = geometry.MultiPoint([(0, 0), (1, 0), (2, 2)])
-
-    assert hash(multipoint) == hash(geometry.MultiPoint([(0, 0), (1, 0), (2, 2)]))
-
-
 def test_empty() -> None:
     multipoint = geometry.MultiPoint([(1, None)])
 

tests/test_multipolygon.py

@@ -284,41 +284,3 @@ def test_empty_bounds() -> None:
     polys = geometry.MultiPolygon([])
 
     assert polys.bounds == ()
-
-
-def test_hash() -> None:
-    polys = geometry.MultiPolygon(
-        (
-            (
-                ((0, 0), (0, 2), (2, 2), (2, 0), (0, 0)),
-                (
-                    ((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),
-                    ((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),
-                ),
-            ),
-            (((0, 0, 0), (1, 1, 0), (1, 0, 0), (0, 0, 0)),),
-            (
-                ((0, 0), (0, 2), (2, 2), (2, 0), (0, 0)),
-                (((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),),
-            ),
-        ),
-    )
-
-    assert hash(polys) == hash(
-        geometry.MultiPolygon(
-            (
-                (
-                    ((0, 0), (0, 2), (2, 2), (2, 0), (0, 0)),
-                    (
-                        ((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),
-                        ((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),
-                    ),
-                ),
-                (((0, 0, 0), (1, 1, 0), (1, 0, 0), (0, 0, 0)),),
-                (
-                    ((0, 0), (0, 2), (2, 2), (2, 0), (0, 0)),
-                    (((1, 0), (0.5, 0.5), (1, 1), (1.5, 0.5), (1, 0)),),
-                ),
-            ),
-        ),
-    )

tests/test_point.py

@@ -57,12 +57,6 @@ def test_xy() -> None:
     assert point.y == 0
 
 
-def test_hash() -> None:
-    point = geometry.Point(1.0, 2.0, 3.0)
-
-    assert hash(point) == hash((1.0, 2.0, 3.0))
-
-
 def test_xy_raises_error_accessing_z() -> None:
     point = geometry.Point(1, 0)
 
@@ -244,9 +238,3 @@ def test_empty_bounds() -> None:
     point = geometry.Point(None, None)
 
     assert point.bounds == ()
-
-
-def test_hash_empty() -> None:
-    point = geometry.Point(None, None)
-
-    assert hash(point) == hash(())

tests/test_polygon.py

@@ -20,12 +20,6 @@ def test_coords_with_holes() -> None:
     )
 
 
-def test_hash() -> None:
-    polygon = geometry.Polygon([(0, 0), (1, 1), (1, 0), (0, 0)])
-
-    assert hash(polygon) == hash(geometry.Polygon([(0, 0), (1, 1), (1, 0), (0, 0)]))
-
-
 def test_geo_interface_shell_only() -> None:
     polygon = geometry.Polygon([(0, 0), (1, 1), (1, 0), (0, 0)])