feat: integration_aws-rds-common: optionalize detectors

modules/integration_aws-rds-common/README.md

@@ -57,7 +57,7 @@ Note the following parameters:
 
 These 3 parameters along with all variables defined in [common-variables.tf](common-variables.tf) are common to all
 [modules](../) in this repository. Other variables, specific to this module, are available in
-[variables-gen.tf](variables-gen.tf).
+[variables.tf](variables.tf) and [variables-gen.tf](variables-gen.tf).
 In general, the default configuration "works" but all of these Terraform
 [variables](https://www.terraform.io/language/values/variables) make it possible to
 customize the detectors behavior to better fit your needs.

modules/integration_aws-rds-common/conf/00-heartbeat.yaml

@@ -4,6 +4,7 @@ name: heartbeat
 transformation: false
 aggregation: ".mean(by=['DBInstanceIdentifier'])"
 filtering: "filter('namespace', 'AWS/RDS')"
+condition: "var.heartbeat_detector_enabled"
 
 signals:
   signal:

modules/integration_aws-rds-common/conf/01-cpu.yaml

@@ -7,6 +7,7 @@ aggregation: ".min(over='15m')"
 
 filtering: "filter('namespace', 'AWS/RDS')"
 value_unit: "%"
+condition: "var.cpu_usage_detector_enabled"
 
 signals:
   signal:

modules/integration_aws-rds-common/conf/02-free-space.yaml

@@ -7,6 +7,7 @@ aggregation: ".min(over='15m')"
 
 filtering: "filter('namespace', 'AWS/RDS')"
 value_unit: "Gibibyte"
+condition: "var.free_space_detector_enabled"
 
 signals:
   signal:

modules/integration_aws-rds-common/conf/03-replica-lag.yaml

@@ -5,6 +5,7 @@ transformation: true
 aggregation: ".min(over='5m')"
 
 filtering: "filter('namespace', 'AWS/RDS')"
+condition: "var.replica_lag_detector_enabled"
 
 signals:
   signal:

modules/integration_aws-rds-common/conf/04-dbload.yaml

@@ -5,6 +5,7 @@ name: "DB Load"
 transformation: true
 aggregation: true
 filtering: "filter('namespace', 'AWS/RDS') and filter('stat', 'mean')"
+condition: "var.dbload_detector_enabled"
 
 signals:
   signal:

modules/integration_aws-rds-common/detectors-gen.tf

@@ -1,4 +1,6 @@
 resource "signalfx_detector" "heartbeat" {
+  count = (var.heartbeat_detector_enabled) ? 1 : 0
+
   name = format("%s %s", local.detector_name_prefix, "AWS RDS Common heartbeat")
 
   authorized_writer_teams = var.authorized_writer_teams
@@ -28,6 +30,8 @@ EOF
 }
 
 resource "signalfx_detector" "cpu_usage" {
+  count = (var.cpu_usage_detector_enabled) ? 1 : 0
+
   name = format("%s %s", local.detector_name_prefix, "AWS RDS Common instance cpu")
 
   authorized_writer_teams = var.authorized_writer_teams
@@ -74,6 +78,8 @@ EOF
 }
 
 resource "signalfx_detector" "free_space_low" {
+  count = (var.free_space_detector_enabled) ? 1 : 0
+
   name = format("%s %s", local.detector_name_prefix, "AWS RDS Common instance free space")
 
   authorized_writer_teams = var.authorized_writer_teams
@@ -120,6 +126,8 @@ EOF
 }
 
 resource "signalfx_detector" "replica_lag" {
+  count = (var.replica_lag_detector_enabled) ? 1 : 0
+
   name = format("%s %s", local.detector_name_prefix, "AWS RDS Common replica lag")
 
   authorized_writer_teams = var.authorized_writer_teams
@@ -161,6 +169,8 @@ EOF
 }
 
 resource "signalfx_detector" "dbload" {
+  count = (var.dbload_detector_enabled) ? 1 : 0
+
   name = format("%s %s", local.detector_name_prefix, "AWS RDS Common db load")
 
   authorized_writer_teams = var.authorized_writer_teams

modules/integration_aws-rds-common/variables.tf

@@ -0,0 +1,29 @@
+variable "heartbeat_detector_enabled" {
+  description = "Enable heartbeat detector"
+  type        = bool
+  default     = true
+}
+
+variable "cpu_usage_detector_enabled" {
+  description = "Enable cpu usage detector"
+  type        = bool
+  default     = true
+}
+
+variable "free_space_detector_enabled" {
+  description = "Enable free space detector"
+  type        = bool
+  default     = true
+}
+
+variable "replica_lag_detector_enabled" {
+  description = "Enable replica lag detector"
+  type        = bool
+  default     = true
+}
+
+variable "dbload_detector_enabled" {
+  description = "Enable dbload detector"
+  type        = bool
+  default     = true
+}