Skip to content

Commit

Permalink
fix(aws-backup): remove aws_account_id variable
Browse files Browse the repository at this point in the history
  • Loading branch information
Nicolas Senaud committed Mar 1, 2024
1 parent 19d1aaa commit a3918fe
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
7 changes: 3 additions & 4 deletions modules/integration_aws-backup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ existing [stack](https://github.com/claranet/terraform-signalfx-detectors/wiki/G
module "signalfx-detectors-integration-aws-backup" {
source = "github.com/claranet/terraform-signalfx-detectors.git//modules/integration_aws-backup?ref={revision}"
environment = var.environment
notifications = local.notifications
aws_account_id = "fillme"
environment = var.environment
notifications = local.notifications
}
```

Expand Down Expand Up @@ -58,7 +57,7 @@ Note the following parameters:

These 3 parameters along with all variables defined in [common-variables.tf](common-variables.tf) are common to all
[modules](../) in this repository. Other variables, specific to this module, are available in
[variables.tf](variables.tf) and [variables-gen.tf](variables-gen.tf).
[variables-gen.tf](variables-gen.tf).
In general, the default configuration "works" but all of these Terraform
[variables](https://www.terraform.io/language/values/variables) make it possible to
customize the detectors behavior to better fit your needs.
Expand Down
2 changes: 1 addition & 1 deletion modules/integration_aws-backup/common-filters.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
# and alerts, since CloudWatch returns aggregated metric, and per vault and
# resource type.
locals {
filters = format("filter('namespace', 'AWS/Backup') and filter('stat', 'sum') and filter('BackupVaultName', '*', match_missing=False) and filter('ResourceType', '*', match_missing=False) and filter('aws_account_id', '%s')", var.aws_account_id)
filters = "filter('namespace', 'AWS/Backup') and filter('stat', 'sum') and filter('BackupVaultName', '*', match_missing=False) and filter('ResourceType', '*', match_missing=False)"
}
3 changes: 0 additions & 3 deletions modules/integration_aws-backup/variables.tf

This file was deleted.

0 comments on commit a3918fe

Please sign in to comment.