Make link toolbar button enabled when text above and link are selected. #17701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… even if the selection starts before the link and includes other elements.
|
I discovered that it's related to general attributes handling mechanism behaviour, as it's reproducible on highlighted nodes. This one is highlighted: ... but this one is not: Not sure if making exception only for links is a good idea 🤔 |
|
It's related to this function: https://github.com/ckeditor/ckeditor5/blob/ck/epic/17230-linking-experience-16965/packages/ckeditor5-engine/src/model/documentselection.ts#L1127-L1142 , it stops lookup after finding first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (link): The
Linktoolbar button should now be enabled when the selection starts at a non-link element and ends at the end of a link. Closes #16965Additional information
Before
before-link-changes-2024-12-31_10.56.17.mp4
After
after-link-changes-2024-12-31_10.53.54.mp4