The link rel attribute should be handled as a token list to allow mixing manual link decorators for the same attribute
#17461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of attributes like class, style, rel or plain attribute.
|
@niegowski added |
|
Before merging, let's discuss the release strategy, if it's coupled or not with linking experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): The link
relattribute should be handled as a token list to allow mixing manual link decorators for the same attribute. Closes #13985, closes #6436.Fix (mention): Mention should not be wrapped with an additional
<span>when GHS is enabled. Closes #15329.Internal (html-support): Attribute matching updated to the new output of
Matcher#matchAll().MINOR BREAKING CHANGE (engine): The
ViewConsumable.consumablesFromElement()is removed and replaced withview.Element#_getConsumables()internal method. You should useViewConsumable.createFrom()To create consumables if needed.MINOR BREAKING CHANGE (engine): The
ViewElementConsumablesnow accepts and outputs only normalized data. TheViewConsumablestill accepts normalized or non-normalized input.MINOR BREAKING CHANGE (engine): The
Matcher#match()andMatcher#matchAll()output is now normalized. TheMatchResult#matchnow contains normalized data compatible with changes in theViewConsumable.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.