Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that preload link tags are injected before stylesheet link tags #22

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 3, 2024

Suggested merge commit message (convention)

Fix: Ensure that preload link tags are injected before stylesheet link tags.


Additional information

This PR ensures that injected stylesheet tags are placed after preload tags, just to make sure the browser properly queues preloading.

Copy link

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

src/utils/injectStylesheet.ts Outdated Show resolved Hide resolved
src/utils/injectStylesheet.ts Outdated Show resolved Hide resolved
tests/cdn/loadCKCdnResourcesPack.test.ts Show resolved Hide resolved
@gorzelinski gorzelinski self-requested a review September 3, 2024 08:31
@Mati365 Mati365 merged commit d61b83e into master Sep 3, 2024
5 checks passed
@Mati365 Mati365 deleted the ck/ensure-preload-tags-are-before-stylesheets branch September 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants