Pass path to a dynamically imported file as file://
protocol URL to make it work in Windows
#1048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (release-tools): Fixed path calculation in
executeInParallel()
util that prepares a path to a dynamically imported worker script. Previously, it did not work in Windows, because there is a specific requirement that absolute path must be validfile://
protocol URL. Now, the worker script is always imported usingfile://
protocol URL.Additional information
Closes cksource/ckeditor5-internal#3882.
I'm not using
url.pathToFileURL()
to convert the path to afile://
protocol URL, because it produces unexpected results in tests where we mockprocess.cwd()
to be Windows-style.Example: when mocked
process.cwd()
isC:\Users\ckeditor
, thenurl.pathToFileURL( 'C:/Users/ckeditor/uuid-4.mjs' )
internally tries to create an URL fromfile://C:%5CUsers%5Cckeditor/C:/Users/ckeditor/uuid-4.mjs
and throwsERR_INVALID_URL
.