Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fields focused demo #48

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Merge fields focused demo #48

wants to merge 9 commits into from

Conversation

andrzejkala
Copy link

@andrzejkala andrzejkala commented Aug 28, 2024

Added:

  • merge fields demo

Changed (added merge fields):

  • feature-rich
  • productivity-pack

@Witoso
Copy link
Member

Witoso commented Aug 29, 2024

Demo feedback:

  • Image is not loading for me, change to <img src="/assets/images/serenity-springs.png" alt="Serenity Springs Resort logo." />
  • Then the image becomes to big, image resize: 35%, adding resize to the image toolbar may be needed. Or should we make the image wide so that it covers full width of the editor, just like emails usually do?
  • I wonder if such a simple (but powerful) demo needs so many features. I would think about doing one line toolbar, and enabling a menu bar for more complex features. Removing: styles, media embed, code, rule, symbols, case change from the top of my head.
  • I think I would put undo/redo first, then merge fields.
  • The demo bleeds tons of warnings: merge-fields-provide-sanitize-function. We need to implement some dom-purify.
  • Should we make it less wide to look more like an email editor?
  • I was surprised that the content with which the editor opens is not a template, I would add it as well to templates.
  • Pagination is not needed as well.
  • I was a little thrown off that templates have different starting, sometimes it's Dear Name, and sometimes Title Last Name :D

Default template:

  • Think about adding a block merge fields before a signature, or maybe a footer, added to all templates?
  • Content is thin in the default template, I would add some AI generated text to make it more realistic. The picture on the top, should we style it, it just looks quite basic.
  • URL merge field in the PS. for the unique discount link?

General demos:

  1. We need to add some fonts, the content just looks worse if we don't have it. Lato same as the Builder could be the safest choice.
  2. I do like the toolbars from the Builder more, links near basic styles, but this might be biased by my high usage. and I don't like how the toolbar breaks.

@usqr
Copy link
Contributor

usqr commented Sep 18, 2024

As an aside note we will probably create a PR later that will update the content & styles as we use a script to export those from the private demos repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants