Update dependencies #298
Merged
Update dependencies #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
force-pushed
the
update-deps2
branch
from
c2a988f to
7cb8136
Compare
KarolDawidziuk
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Hi @Comandeer
There are a few packages that we can update, especially the typescript, let's update it and we'll be ready to merge.
|
@KarolDawidziuk, thx for the review! I've bumped the deps, except the |
KarolDawidziuk
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Thanks, @Comandeer for the improvements.
LGTM! 🎉
There is one failing test that we should check. It's can be related to an outdated version of the nightwatch package, so we should check if fixing #287 will help.
KarolDawidziuk
force-pushed
the
update-deps2
branch
from
51a946b to
76f909b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.