Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds feature to aggregate identical CombatPreview ModifierStrings #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slothoth
Copy link

In the unit Combat Preview, strength modifers are listed, even if the values are identical. This can lead to UI bloat if many modifiers are present, as seen in the modded example.

image

To fix this, Modifier strings are stored and duplicate strings are instead aggregated, I.E. In the mod example, I have given the Battlecry promo a second copy of its normal modifier, but instead of +7 twice, it sums it as +14.

image

I am planning on releasing this change with my own associated mod, but other modders have expressed interest in using it, but are not Lua programmers. I figured a good comprise might be a home in CQUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant