Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [role="status"] #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support [role="status"] #40

wants to merge 1 commit into from

Conversation

seanpdoyle
Copy link
Contributor

Add a :status selector in the same style as the :alert selector.

Additionally, extend both the :alert and :status selectors to accept
text as a locator argument.

@seanpdoyle
Support [role="status"]
a182e11 
Add a `:status` selector in the same style as the `:alert` selector.

Additionally, extend both the `:alert` and `:status` selectors to accept
text as a locator argument.
@seanpdoyle
Copy link
Contributor Author

@mrdaniellewis would you mind reviewing this diff?

@mrdaniellewis
Copy link
Contributor

I'm still thinking about this one. I'm not sure the alert selector was actually very useful. Both this and alert can have an accessible name as well.

<output> also has an implicit role of status.

They both create an aria-live region. At some point I want to do a has_live_message, type thing, but it is tricky as you need to monitor the children for changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpdoyle @mrdaniellewis