PLATFORM-366 Fix mypy structural errors for library #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwgill
force-pushed
the
PLATFORM-366_fix_mypy_structural_errors_for_library
branch
from
1a9c59a to
15a926f
Compare
michelesr
reviewed
Jan 9, 2024
michelesr
reviewed
Jan 9, 2024
| @@ -30,3 +31,9 @@ select = ['E', 'W', 'F', 'C', 'N'] | |||
| ignore = ['E501'] | |||
| line-length = 95 | |||
| exclude = ["ca_cdk_constructs/eks/imports"] | |||
|
|
|||
| [[tool.mypy.overrides]] | |||
There was a problem hiding this comment.
why the double square brackets?
There was a problem hiding this comment.
Good question, that was the example from mypy. Not sure what it's doing in pyproject syntax, but I'll have to have a look
There was a problem hiding this comment.
It's the TOML table array syntax. It means you can have multiple [[tool.mypy.overrides]] elements, each one setting a different config for different packages.
simonwgill
force-pushed
the
PLATFORM-366_fix_mypy_structural_errors_for_library
branch
from
15a926f to
0c23cb3
Compare
simonwgill
force-pushed
the
PLATFORM-366_fix_mypy_structural_errors_for_library
branch
from
0c23cb3 to
3b01d88
Compare
zhelyan
approved these changes
Jan 10, 2024
michelesr
deleted the
PLATFORM-366_fix_mypy_structural_errors_for_library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Testing using a git reference to this branch and importing into eks-platform-cdk. This removes the errors from the library being structured badly.
The change will all the null coalescing could have been done another way. The problem was that the argument was being passed directly from a function with optional arguments and a default to a function which required a non-null argument. This change doesn't affect the interface at all, so it's the one I've gone with, but one of the other alternatives of changing the function definitions might be the way forward in the long run..
Checklist before requesting a review