Fix CBOR data encoding #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fluffy Can you, please, review this PR? |
|
Closed due to inactivity. |
|
Probably Carsten is right person to review this but it looks about right to me. Why did you close it ? |
@fluffy I closed this PR because I thought this repo is not maintained anymore. Also, we created a lightweight SenML lib because it was easier to maintain our code. Feel free to reopen, but the merge of #24 will resolve this issue. Also, please note that #23 is probably duplicate #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compactness, CBOR representation uses integers for labels, as described here. For that reason, SenML records are transformed to
map[int]interface{}before encoding to CBOR.