Do not use -Werror #3809
Merged
Do not use -Werror #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using -Werror can cause builds to fail when using unexpected compilers.
1svdgfg
approved these changes
Nov 21, 2024
| @@ -41,7 +41,6 @@ cpu_family = host_machine.cpu_family() | |||
|
|
|||
| supported_arguments = cpp.get_supported_arguments([ | |||
| '-Wno-non-virtual-dtor', | |||
| '-Werror', | |||
| '-Wunused-but-set-variable', | |||
| '-Wno-strict-aliasing']) | |||
|
|
|||
alyssais
approved these changes
Nov 26, 2024
13 tasks
alyssais
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 30, 2024
-Werror isn't suitable for distro builds because it means new breakages can appear before upstream has a chance to do anything about them, and they might not be worth failing the build over. Fixes building for musl. Link: cisco/openh264#3809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
-Werrorcan cause builds to fail when using unexpected compilers.For example: https://trac.macports.org/ticket/71354
By all means, manually add
-Werrorto your CI if you want to ensure warning-free builds using compilers you're testing, but don't force it on your users and make their builds fail just because they're using a compiler that has a warning you didn't anticipate.