Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded OpenJDK install from docker images and updated Elastisearch to 7.17.8 #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zozman
Copy link
Contributor

@Zozman Zozman commented Jan 5, 2023

Summary

As described in the documentation for Elastisearch 7, the download of Elastisearch includes a bundled version of OpenJDK within the jdk directory of the download that Elastisearch recommends be used. Because of this, there is no need to manually install OpenJDK in the Docker images as Elastisearch not only already had it in the download (to see an example, download and uncompress https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-7.17.8-linux-x86_64.tar.gz) but is also set to use it by default. So this PR removes the Docker commands to perform this install as it's not needed, makes the container builds faster, and removes the burden of keeping the OpenJDK up to date from the Dockerfile.

In addition, also updated Elastisearch inside the Docker containers to 7.17.8 as updating this version to deal with https://www.cve.org/CVERecord?id=CVE-2021-44228 that's mentioned in #386 has never been done.

To Test

  • To test the container in the docker_containers/mindmeld_docker directory, run docker-compose up --build from this directory.
  • To test the container in the docker_containers/mindmeld_dep_docker directory, run docker-compose up --build from this directory.

@vrdn-23 vrdn-23 self-requested a review March 2, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant