Removed unneeded OpenJDK install from docker images and updated Elastisearch to 7.17.8 #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in the documentation for Elastisearch 7, the download of Elastisearch includes a bundled version of OpenJDK within the
jdk
directory of the download that Elastisearch recommends be used. Because of this, there is no need to manually install OpenJDK in the Docker images as Elastisearch not only already had it in the download (to see an example, download and uncompress https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-7.17.8-linux-x86_64.tar.gz) but is also set to use it by default. So this PR removes the Docker commands to perform this install as it's not needed, makes the container builds faster, and removes the burden of keeping the OpenJDK up to date from the Dockerfile.In addition, also updated Elastisearch inside the Docker containers to 7.17.8 as updating this version to deal with https://www.cve.org/CVERecord?id=CVE-2021-44228 that's mentioned in #386 has never been done.
To Test
docker_containers/mindmeld_docker
directory, rundocker-compose up --build
from this directory.docker_containers/mindmeld_dep_docker
directory, rundocker-compose up --build
from this directory.