Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r7rs character names #323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ecraven
Copy link

@ecraven ecraven commented Jun 22, 2018

Make ChezScheme read #\escape and #\null, and also | inside strings.
This does nothing about actually writing, it is just meant to make interoperability with R7RS schemes easier.

@dybvig
Copy link
Member

dybvig commented Jul 9, 2018

I don't object to these changes, but I'm curious. What is the point of treating | as | inside a string?

In the implementation, it seems better to handle it in the case just just above the one your modified that handles \ and " similarly. Please add a LOG entry and a couple of mats.

@ecraven
Copy link
Author

ecraven commented Feb 21, 2019

@dybvig I'll rewrite the patch accordingly.
It seems the only reason | is included is for compatibility with '|foo|bar|. Not a decision I know how to defend myself, but it is what r7rs is ;)

@ecraven
Copy link
Author

ecraven commented Feb 21, 2019

When asking on #scheme (2018-06-22), the answer was:
\| is necessary when escaping symbols, and we allowed it in strings for uniformity

@akeep
Copy link
Contributor

akeep commented Jun 19, 2021

Recognizing that this a relatively small change, it should probably update the documentation to reflect the added character names and string escape. The LOG entries should also include the modified file, as the other entries in the LOG do.

@omasanori
Copy link

May I help with something if it is stalled?

@burgerrg
Copy link
Contributor

@ecraven, if you'd like to proceed with this change, please update the documentation and release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants